[
https://issues.apache.org/jira/browse/GOBBLIN-1004?focusedWorklogId=359737&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-359737
]
ASF GitHub Bot logged work on GOBBLIN-1004:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Dec/19 02:08
Start Date: 14/Dec/19 02:08
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2850: [GOBBLIN-1004]
Downgrade Helix version at compile time to fix slf4j dependency
URL:
https://github.com/apache/incubator-gobblin/pull/2850#issuecomment-565667272
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2850?src=pr&el=h1)
Report
> Merging
[#2850](https://codecov.io/gh/apache/incubator-gobblin/pull/2850?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/7d94e4745c71f4b01c61828216fc90c626a9521a?src=pr&el=desc)
will **decrease** coverage by `<.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2850?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2850 +/- ##
============================================
- Coverage 45.51% 45.51% -0.01%
- Complexity 8994 8995 +1
============================================
Files 1904 1904
Lines 71564 71564
Branches 7889 7889
============================================
- Hits 32573 32572 -1
- Misses 35987 35991 +4
+ Partials 3004 3001 -3
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2850?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2850/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `32.71% <0%> (-2.81%)` | `11% <0%> (-1%)` | |
|
[.../limiter/RedirectAwareRestClientRequestSender.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2850/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9SZWRpcmVjdEF3YXJlUmVzdENsaWVudFJlcXVlc3RTZW5kZXIuamF2YQ==)
| `84.88% <0%> (-2.33%)` | `17% <0%> (-1%)` | |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2850/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `64.81% <0%> (-0.47%)` | `28% <0%> (ø)` | |
|
[.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2850/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=)
| `80.37% <0%> (+0.93%)` | `24% <0%> (ø)` | :arrow_down: |
|
[...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2850/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=)
| `64.44% <0%> (+1.11%)` | `16% <0%> (+1%)` | :arrow_up: |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2850/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `100% <0%> (+14.28%)` | `4% <0%> (+1%)` | :arrow_up: |
|
[...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2850/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh)
| `60% <0%> (+20%)` | `3% <0%> (+1%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2850?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2850?src=pr&el=footer).
Last update
[7d94e47...b1a6e13](https://codecov.io/gh/apache/incubator-gobblin/pull/2850?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 359737)
Time Spent: 50m (was: 40m)
> Helix version introduces incompatible slf4j version
> ---------------------------------------------------
>
> Key: GOBBLIN-1004
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1004
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: William Lo
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The version of Helix from [GOBBLIN-996] downloads a transitive dependency of
> slf4j, version 1.7.25, that is incompatible with the current dependency of
> slf4j 1.7.21
> Causes this error to be raised immediately at runtime.
> {code:java}
> Exception in thread "main" java.lang.NoSuchMethodError:
> org.slf4j.helpers.Util.safeGetSystemProperty(Ljava/lang/String;)Ljava/lang/String;
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
