sv2000 commented on a change in pull request #2851: [GOBBLIN-1006] Enable
configurable case-preserving and schema source-of-truth in table level
properties
URL: https://github.com/apache/incubator-gobblin/pull/2851#discussion_r359114101
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/entities/StageableTableMetadata.java
##########
@@ -92,6 +98,12 @@
*/
public static final String SOURCE_DATA_PATH_IDENTIFIER_KEY =
"source.dataPathIdentifier";
+ /**
+ * Attributes like "avro.schema.literal" are usually used in offline system
as the source-of-truth of schema.
+ * This configuration's value should be the key name that users expects to
preserve to schema string if necessary.
+ */
+ public static final String SCHEMA_SOURCE_OF_TRUTH = "schema.sourceOfTruth";
Review comment:
Call it "schema.original"? schema.sourceOfTruth refers to the source where
you obtained the schema from, which does not look like how you are setting this
property.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
