[
https://issues.apache.org/jira/browse/GOBBLIN-1012?focusedWorklogId=365941&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-365941
]
ASF GitHub Bot logged work on GOBBLIN-1012:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jan/20 18:47
Start Date: 03/Jan/20 18:47
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2857: [GOBBLIN-1012]
Implement CompactionWithWatermarkSuite
URL:
https://github.com/apache/incubator-gobblin/pull/2857#issuecomment-570405736
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2857?src=pr&el=h1)
Report
> Merging
[#2857](https://codecov.io/gh/apache/incubator-gobblin/pull/2857?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/4483268e3885adb63da7253df5ab0c00eb86aece?src=pr&el=desc)
will **increase** coverage by `0.04%`.
> The diff coverage is `69.91%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2857?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2857 +/- ##
============================================
+ Coverage 45.72% 45.76% +0.04%
- Complexity 9085 9105 +20
============================================
Files 1913 1917 +4
Lines 72021 72131 +110
Branches 7943 7956 +13
============================================
+ Hits 32929 33009 +80
- Misses 36074 36098 +24
- Partials 3018 3024 +6
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2857?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...ion/suite/CompactionWithWatermarkSuiteFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2857/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vc3VpdGUvQ29tcGFjdGlvbldpdGhXYXRlcm1hcmtTdWl0ZUZhY3RvcnkuamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (?)` | |
|
[...compaction/suite/CompactionWithWatermarkSuite.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2857/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vc3VpdGUvQ29tcGFjdGlvbldpdGhXYXRlcm1hcmtTdWl0ZS5qYXZh)
| `0% <0%> (ø)` | `0 <0> (?)` | |
|
[...ta/management/dataset/TimePartitionGlobFinder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2857/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2RhdGFzZXQvVGltZVBhcnRpdGlvbkdsb2JGaW5kZXIuamF2YQ==)
| `93.61% <100%> (+0.21%)` | `24 <0> (+1)` | :arrow_up: |
|
[...gobblin/compaction/mapreduce/MRCompactionTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2857/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vbWFwcmVkdWNlL01SQ29tcGFjdGlvblRhc2suamF2YQ==)
| `76.19% <66.66%> (+0.58%)` | `9 <0> (ø)` | :arrow_down: |
|
[...n/compaction/action/CompactionWatermarkAction.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2857/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vYWN0aW9uL0NvbXBhY3Rpb25XYXRlcm1hcmtBY3Rpb24uamF2YQ==)
| `77.04% <77.04%> (ø)` | `11 <11> (?)` | |
|
[.../compaction/verify/CompactionWatermarkChecker.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2857/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vdmVyaWZ5L0NvbXBhY3Rpb25XYXRlcm1hcmtDaGVja2VyLmphdmE=)
| `92.85% <92.85%> (ø)` | `9 <9> (?)` | |
|
[...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2857/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh)
| `40% <0%> (-20%)` | `2% <0%> (-1%)` | |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2857/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `85.71% <0%> (-14.29%)` | `3% <0%> (-1%)` | |
|
[...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2857/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==)
| `30.2% <0%> (-0.68%)` | `24% <0%> (-1%)` | |
| ... and [7
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2857/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2857?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2857?src=pr&el=footer).
Last update
[4483268...8a5349f](https://codecov.io/gh/apache/incubator-gobblin/pull/2857?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 365941)
Time Spent: 1h (was: 50m)
> Implement CompactionWithWatermarkSuite
> --------------------------------------
>
> Key: GOBBLIN-1012
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1012
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zhixiong Chen
> Assignee: Zhixiong Chen
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> - A `compactionWatermark` is a timestamp indicating the data we've seen up to
> that time is compacted. If we explicitly checked that we've seen all the data
> up to that time, the timestamp would be published also as
> `completionAndCompactionWatermark`.
> - `CompactionWithWatermarkSuite` reports compaction watermarks as part of
> the compaction pipeline and publishes watermarks as hive table properties
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
