[
https://issues.apache.org/jira/browse/GOBBLIN-1014?focusedWorklogId=366106&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-366106
]
ASF GitHub Bot logged work on GOBBLIN-1014:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Jan/20 00:05
Start Date: 04/Jan/20 00:05
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2858: [GOBBLIN-1014] Fix
error handling in gobblin.sh
URL:
https://github.com/apache/incubator-gobblin/pull/2858#issuecomment-570699740
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=h1)
Report
> Merging
[#2858](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/d18783df7ab29b161cca59ca907fb47e1366b358?src=pr&el=desc)
will **increase** coverage by `0.95%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2858 +/- ##
============================================
+ Coverage 44.8% 45.75% +0.95%
- Complexity 8933 9105 +172
============================================
Files 1917 1917
Lines 72131 72131
Branches 7956 7956
============================================
+ Hits 32316 33006 +690
+ Misses 36832 36100 -732
- Partials 2983 3025 +42
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...lin/elasticsearch/writer/FutureCallbackHolder.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tZWxhc3RpY3NlYXJjaC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9lbGFzdGljc2VhcmNoL3dyaXRlci9GdXR1cmVDYWxsYmFja0hvbGRlci5qYXZh)
| `61.42% <0%> (-1.43%)` | `4% <0%> (ø)` | |
|
[...src/main/java/org/apache/gobblin/runtime/Task.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFzay5qYXZh)
| `67.05% <0%> (+0.23%)` | `82% <0%> (+1%)` | :arrow_up: |
|
[.../org/apache/gobblin/runtime/SafeDatasetCommit.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvU2FmZURhdGFzZXRDb21taXQuamF2YQ==)
| `47.31% <0%> (+0.48%)` | `29% <0%> (ø)` | :arrow_down: |
|
[...rg/apache/gobblin/runtime/AbstractJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvQWJzdHJhY3RKb2JMYXVuY2hlci5qYXZh)
| `59.78% <0%> (+0.79%)` | `36% <0%> (+2%)` | :arrow_up: |
|
[...ain/java/org/apache/gobblin/runtime/fork/Fork.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvZm9yay9Gb3JrLmphdmE=)
| `75% <0%> (+0.83%)` | `68% <0%> (ø)` | :arrow_down: |
|
[.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=)
| `80.37% <0%> (+0.93%)` | `24% <0%> (ø)` | :arrow_down: |
|
[...in/java/org/apache/gobblin/runtime/JobContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvSm9iQ29udGV4dC5qYXZh)
| `76.37% <0%> (+2.19%)` | `50% <0%> (+1%)` | :arrow_up: |
|
[...va/org/apache/gobblin/runtime/util/JobMetrics.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvdXRpbC9Kb2JNZXRyaWNzLmphdmE=)
| `73.68% <0%> (+2.63%)` | `13% <0%> (+1%)` | :arrow_up: |
|
[.../gobblin/runtime/job/JobInterruptionPredicate.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iL0pvYkludGVycnVwdGlvblByZWRpY2F0ZS5qYXZh)
| `59.45% <0%> (+2.7%)` | `8% <0%> (+1%)` | :arrow_up: |
|
[...apache/gobblin/runtime/local/LocalJobLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9jYWwvTG9jYWxKb2JMYXVuY2hlci5qYXZh)
| `61.81% <0%> (+3.63%)` | `5% <0%> (+1%)` | :arrow_up: |
| ... and [35
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2858/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=footer).
Last update
[d18783d...26caf4c](https://codecov.io/gh/apache/incubator-gobblin/pull/2858?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 366106)
Time Spent: 0.5h (was: 20m)
> Gobblin.sh script uses undeclared error-handling function
> ---------------------------------------------------------
>
> Key: GOBBLIN-1014
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1014
> Project: Apache Gobblin
> Issue Type: Bug
> Affects Versions: 0.15.0
> Reporter: Alex Prokofiev
> Priority: Minor
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> This script uses "die" function that is not declared -
> [https://github.com/apache/incubator-gobblin/blob/master/bin/gobblin.sh#L436]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
