sv2000 opened a new pull request #2863: GOBBLIN-1016: Allow Gobblin Application Master to join Helix cluster … URL: https://github.com/apache/incubator-gobblin/pull/2863 Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-1016 ### Description - [x] Here are some details about my PR, including screenshots (if applicable): In the managed cluster mode, the Gobblin Yarn Application Master joins Helix cluster in the ADMINISTRATOR role. However, Helix does not support messaging for instances which are not CONTROLLER or PARTICIPANT. To properly handle shutdown and token file update messages, the AppMaster should connect to the Helix cluster as a PARTICIPANT, these message types need to be destined to PARTICIPANT instead of CONTROLLER as is the case today. ### Tests - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: Added unit tests to YarnAppSecurityManagerTest and GobblinYarnAppLauncherTest classes. ### Commits - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how"
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
