[
https://issues.apache.org/jira/browse/GOBBLIN-1018?focusedWorklogId=371844&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-371844
]
ASF GitHub Bot logged work on GOBBLIN-1018:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Jan/20 19:54
Start Date: 14/Jan/20 19:54
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2864:
GOBBLIN-1018: Report GC counts and durations from Gobblin containers …
URL: https://github.com/apache/incubator-gobblin/pull/2864#discussion_r366541788
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/ContainerHealthMetricsService.java
##########
@@ -94,35 +133,75 @@ protected void runOneIteration() throws Exception {
this.totalSwapSpaceSize.set(this.operatingSystemMXBean.getTotalSwapSpaceSize());
this.freePhysicalMemSize.set(this.operatingSystemMXBean.getFreePhysicalMemorySize());
this.processHeapUsedSize.set(this.memoryMXBean.getHeapMemoryUsage().getUsed());
+
+ GcStats gcStats = collectGcStats();
+ //Since GC Beans report accumulated counts/durations, we need to subtract
the previous values to obtain the counts/durations
+ // since the last measurement time.
+ this.minorGcCount.set(gcStats.getMinorCount() - this.minorGcCount.get());
Review comment:
Just curious, when printed, do we have any mention of this duration ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 371844)
Time Spent: 50m (was: 40m)
> Report GC counts and durations from Gobblin containers metrics service
> ------------------------------------------------------------------------
>
> Key: GOBBLIN-1018
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1018
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-cluster
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Hung Tran
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> The container health metrics service should report minor/major GC counts and
> durations.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
