htran1 commented on a change in pull request #2868: GOBBLIN-1025: Add retry for
PK-Chuking iterator
URL: https://github.com/apache/incubator-gobblin/pull/2868#discussion_r367155043
##########
File path:
gobblin-salesforce/src/main/java/org/apache/gobblin/salesforce/SalesforceConfigurationKeys.java
##########
@@ -26,12 +26,12 @@ private SalesforceConfigurationKeys() {
public static final String BULK_API_USE_QUERY_ALL =
"salesforce.bulkApiUseQueryAll";
// pk-chunking
- public static final String PK_CHUNKING_TEST_BATCH_ID_LIST =
"salesforce.pkChunking.testBatchIdList";
- public static final String PK_CHUNKING_TEST_JOB_ID =
"salesforce.pkChunking.testJobId";
+ public static final String BULK_TEST_JOB_ID = "salesforce.bulk.test.job.id";
Review comment:
Please follow the config naming convention of using '.' as namespace
separators, so this should be "salesforce.bulk.testJobId". Change the other new
keys to conform.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
