sv2000 commented on a change in pull request #2872: Refactor
AbstractYarnSecurityManager to expose method for sending token file update
message
URL: https://github.com/apache/incubator-gobblin/pull/2872#discussion_r367657309
##########
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/AbstractYarnAppSecurityManager.java
##########
@@ -166,6 +175,15 @@ public void loginAndScheduleTokenRenewal() {
}
}
+ protected void sendTokenFileUpdatedMessage() {
+ // Send a message to the controller (when the cluster is not managed)
+ // and all the participants if this is not the first login
+ if (!this.isHelixClusterManaged) {
Review comment:
In the managed mode, the GobblinClusterManager joins as a PARTICIPANT and
hence, will get the token file updated message and handle the refresh. In the
managed mode, sending this message to the controller will only queue messages
on the CONTROLLER, since the CONTROLLER will likely not have a handler. In the
unmanaged cluster mode, we maintain the same behavior as before, sending the
updated message to both CONTROLLER and PARTICIPANT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
