[
https://issues.apache.org/jira/browse/GOBBLIN-1032?focusedWorklogId=377027&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-377027
]
ASF GitHub Bot logged work on GOBBLIN-1032:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jan/20 20:22
Start Date: 24/Jan/20 20:22
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2874: GOBBLIN-1032:
Provide Helix instance tags config to GobblinYarnTaskRu…
URL:
https://github.com/apache/incubator-gobblin/pull/2874#issuecomment-578285862
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2874?src=pr&el=h1)
Report
> Merging
[#2874](https://codecov.io/gh/apache/incubator-gobblin/pull/2874?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/adb0efcc20a306d16b2f59d89c189539bd20dc2d?src=pr&el=desc)
will **decrease** coverage by `0.95%`.
> The diff coverage is `7.14%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2874?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2874 +/- ##
============================================
- Coverage 45.8% 44.84% -0.96%
+ Complexity 9108 8939 -169
============================================
Files 1915 1915
Lines 72266 72293 +27
Branches 7969 7974 +5
============================================
- Hits 33098 32423 -675
- Misses 36143 36887 +744
+ Partials 3025 2983 -42
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2874?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...bblin/cluster/GobblinClusterConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2874/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJDb25maWd1cmF0aW9uS2V5cy5qYXZh)
| `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2874/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `64.22% <0%> (-1.06%)` | `28 <0> (ø)` | |
|
[...org/apache/gobblin/yarn/GobblinYarnTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2874/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5UYXNrUnVubmVyLmphdmE=)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...main/java/org/apache/gobblin/yarn/YarnService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2874/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFyblNlcnZpY2UuamF2YQ==)
| `15.32% <12.5%> (+0.15%)` | `4 <0> (ø)` | :arrow_down: |
|
[...re/filesystem/FsDatasetStateStoreEntryManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2874/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWV0YXN0b3JlL2ZpbGVzeXN0ZW0vRnNEYXRhc2V0U3RhdGVTdG9yZUVudHJ5TWFuYWdlci5qYXZh)
| `0% <0%> (-100%)` | `0% <0%> (-3%)` | |
|
[...askStateCollectorServiceHiveRegHandlerFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2874/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFza1N0YXRlQ29sbGVjdG9yU2VydmljZUhpdmVSZWdIYW5kbGVyRmFjdG9yeS5qYXZh)
| `0% <0%> (-100%)` | `0% <0%> (-2%)` | |
|
[...gobblin/runtime/mapreduce/GobblinOutputFormat.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2874/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL0dvYmJsaW5PdXRwdXRGb3JtYXQuamF2YQ==)
| `0% <0%> (-100%)` | `0% <0%> (-2%)` | |
|
[...in/runtime/mapreduce/CustomizedProgresserBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2874/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL0N1c3RvbWl6ZWRQcm9ncmVzc2VyQmFzZS5qYXZh)
| `0% <0%> (-83.34%)` | `0% <0%> (-1%)` | |
|
[...rg/apache/gobblin/runtime/ZkDatasetStateStore.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2874/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4taGVsaXgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9aa0RhdGFzZXRTdGF0ZVN0b3JlLmphdmE=)
| `0% <0%> (-80.77%)` | `0% <0%> (-7%)` | |
|
[...lin/runtime/locks/LegacyJobLockFactoryManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2874/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvTGVnYWN5Sm9iTG9ja0ZhY3RvcnlNYW5hZ2VyLmphdmE=)
| `0% <0%> (-78.58%)` | `0% <0%> (-2%)` | |
| ... and [42
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2874/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2874?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2874?src=pr&el=footer).
Last update
[adb0efc...a6a6aff](https://codecov.io/gh/apache/incubator-gobblin/pull/2874?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 377027)
Time Spent: 40m (was: 0.5h)
> Provide Helix instance tags config to GobblinYarnTaskRunner during container
> start up
> -------------------------------------------------------------------------------------
>
> Key: GOBBLIN-1032
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1032
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-yarn
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Abhishek Tiwari
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Helix instance tags is useful to target Helix jobs to instances based on user
> provided tags. In particular, in managed cluster mode where the
> GobblinAppMaster joins the Helix cluster as a PARTICIPANT, the instance tags
> allow Helix to exclude the App master from getting tasks assigned.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
