[
https://issues.apache.org/jira/browse/GOBBLIN-1038?focusedWorklogId=380268&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-380268
]
ASF GitHub Bot logged work on GOBBLIN-1038:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Feb/20 00:18
Start Date: 01/Feb/20 00:18
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on pull request #2880:
[GOBBLIN-1038] Set default dataset descriptor configs based on the DataNode
URL: https://github.com/apache/incubator-gobblin/pull/2880#discussion_r373738144
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/flowgraph/pathfinder/AbstractPathFinder.java
##########
@@ -103,6 +105,11 @@
this.destNodes.add(destNode);
}
+ // All dest nodes should be the same class
+ if (this.destNodes != null &&
this.destNodes.stream().map(Object::getClass).collect(Collectors.toSet()).size()
> 1) {
Review comment:
Can our path finding algorithm return dest nodes with different types? just
curious.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 380268)
Time Spent: 0.5h (was: 20m)
> Set default dataset descriptor configs based on the DataNode
> ------------------------------------------------------------
>
> Key: GOBBLIN-1038
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1038
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
