autumnust commented on a change in pull request #2883: GOBBLIN-1043: Implement a Helix assigned participant check as a Commi… URL: https://github.com/apache/incubator-gobblin/pull/2883#discussion_r376242187
########## File path: gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinClusterConfigurationKeys.java ########## @@ -183,4 +185,11 @@ public static final boolean DEFAULT_IS_HELIX_CLUSTER_MANAGED = false; public static final String HADOOP_CONFIG_OVERRIDES_PREFIX = GOBBLIN_CLUSTER_PREFIX + "hadoop.inject"; + + //Configuration keys that will be set dynamically. + public static final String HELIX_JOB_ID_KEY = GOBBLIN_CLUSTER_PREFIX + "helixJobId"; Review comment: Let's add different prefix to differentiate from exposed configuration ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
