[
https://issues.apache.org/jira/browse/GOBBLIN-1043?focusedWorklogId=383745&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-383745
]
ASF GitHub Bot logged work on GOBBLIN-1043:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 07/Feb/20 17:32
Start Date: 07/Feb/20 17:32
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2883: GOBBLIN-1043:
Implement a Helix assigned participant check as a Commi…
URL:
https://github.com/apache/incubator-gobblin/pull/2883#issuecomment-583194748
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2883?src=pr&el=h1)
Report
> Merging
[#2883](https://codecov.io/gh/apache/incubator-gobblin/pull/2883?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/ef3003c85531aaeacb760a4e30fca2d3069001aa?src=pr&el=desc)
will **decrease** coverage by `0.97%`.
> The diff coverage is `35.63%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2883?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2883 +/- ##
============================================
- Coverage 45.73% 44.75% -0.98%
+ Complexity 9112 8944 -168
============================================
Files 1921 1923 +2
Lines 72391 72474 +83
Branches 7967 7974 +7
============================================
- Hits 33106 32434 -672
- Misses 36262 37058 +796
+ Partials 3023 2982 -41
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2883?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...bblin/cluster/GobblinClusterConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2883/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJDb25maWd1cmF0aW9uS2V5cy5qYXZh)
| `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...gobblin/cluster/HelixAssignedParticipantCheck.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2883/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhBc3NpZ25lZFBhcnRpY2lwYW50Q2hlY2suamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (?)` | |
|
[...org/apache/gobblin/commit/CommitStepException.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2883/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vY29tbWl0L0NvbW1pdFN0ZXBFeGNlcHRpb24uamF2YQ==)
| `0% <0%> (ø)` | `0 <0> (?)` | |
|
[...rg/apache/gobblin/cluster/TaskRunnerSuiteBase.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2883/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvVGFza1J1bm5lclN1aXRlQmFzZS5qYXZh)
| `93.61% <100%> (+0.93%)` | `2 <0> (ø)` | :arrow_down: |
|
[...pache/gobblin/cluster/GobblinHelixTaskFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2883/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFza0ZhY3RvcnkuamF2YQ==)
| `100% <100%> (ø)` | `10 <3> (+2)` | :arrow_up: |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2883/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `64.91% <71.42%> (+0.2%)` | `29 <0> (ø)` | :arrow_down: |
|
[...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2883/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh)
| `77.41% <72.22%> (-3.02%)` | `6 <2> (+1)` | |
|
[...re/filesystem/FsDatasetStateStoreEntryManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2883/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWV0YXN0b3JlL2ZpbGVzeXN0ZW0vRnNEYXRhc2V0U3RhdGVTdG9yZUVudHJ5TWFuYWdlci5qYXZh)
| `0% <0%> (-100%)` | `0% <0%> (-3%)` | |
|
[...askStateCollectorServiceHiveRegHandlerFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2883/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvVGFza1N0YXRlQ29sbGVjdG9yU2VydmljZUhpdmVSZWdIYW5kbGVyRmFjdG9yeS5qYXZh)
| `0% <0%> (-100%)` | `0% <0%> (-2%)` | |
|
[...gobblin/runtime/mapreduce/GobblinOutputFormat.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2883/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbWFwcmVkdWNlL0dvYmJsaW5PdXRwdXRGb3JtYXQuamF2YQ==)
| `0% <0%> (-100%)` | `0% <0%> (-2%)` | |
| ... and [45
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2883/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2883?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2883?src=pr&el=footer).
Last update
[ef3003c...ca769e1](https://codecov.io/gh/apache/incubator-gobblin/pull/2883?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 383745)
Time Spent: 1h 10m (was: 1h)
> Implement a Helix assigned participant check as a CommitStep
> ------------------------------------------------------------
>
> Key: GOBBLIN-1043
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1043
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-cluster
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Hung Tran
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> In Gobblin Helix cluster, we encounter scenarios where a participant
> continues to work on a Helix partition even after the partition has been
> assigned by Helix to a different participant leading to duplicate
> consumption. We implement a check where each Helix task checks if it is
> indeed the currently assigned participant for the Helix partition. This check
> is implemented as a CommitStep and can be used as an assertion before data
> publish occurs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
