[
https://issues.apache.org/jira/browse/GOBBLIN-1046?focusedWorklogId=386111&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386111
]
ASF GitHub Bot logged work on GOBBLIN-1046:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 12/Feb/20 18:27
Start Date: 12/Feb/20 18:27
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2886:
[GOBBLIN-1046] Make /final subdir configurable in ORC-conversion output
URL: https://github.com/apache/incubator-gobblin/pull/2886#discussion_r378432496
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/conversion/hive/dataset/ConvertibleHiveDataset.java
##########
@@ -141,14 +141,23 @@ public ConvertibleHiveDataset(FileSystem fs,
HiveMetastoreClientPool clientPool,
String destTable =
conversionConfigForFormat.get().getDestinationDbName() + "." +
conversionConfigForFormat.get()
.getDestinationTableName();
DatasetDescriptor dest = new
DatasetDescriptor(DatasetConstants.PLATFORM_HIVE, destTable);
- String destLocation =
conversionConfigForFormat.get().getDestinationDataPath() + Path.SEPARATOR +
"final";
+ String destLocation =
conversionConfigForFormat.get().getDataDstPathUseSubdir()
+ ?
getFinalizedDestinationLocation(conversionConfigForFormat.get().getDestinationDataPath())
+ : conversionConfigForFormat.get().getDestinationDataPath();
dest.addMetadata(DatasetConstants.FS_SCHEME,
getSourceDataset().getMetadata().get(DatasetConstants.FS_SCHEME));
dest.addMetadata(DatasetConstants.FS_LOCATION, destLocation);
destDatasets.add(dest);
}
return destDatasets;
}
+ /**
+ * The default behavior for ORC output in Avro2ORC is to add subdir
"/final" under destination path from Config.
+ */
+ public static final String getFinalizedDestinationLocation(String
destinationDataPathFromConfig) {
+ return destinationDataPathFromConfig + Path.SEPARATOR + "final";
Review comment:
Addressed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 386111)
Time Spent: 0.5h (was: 20m)
> Make ORC-Conversion output subdirectory configurable
> ----------------------------------------------------
>
> Key: GOBBLIN-1046
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1046
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
