[ 
https://issues.apache.org/jira/browse/GOBBLIN-1048?focusedWorklogId=386285&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386285
 ]

ASF GitHub Bot logged work on GOBBLIN-1048:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 12/Feb/20 22:31
            Start Date: 12/Feb/20 22:31
    Worklog Time Spent: 10m 
      Work Description: codecov-io commented on issue #2888: GOBBLIN-1048: 
Provide an option to pass and set System properties via…
URL: 
https://github.com/apache/incubator-gobblin/pull/2888#issuecomment-585451492
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2888?src=pr&el=h1)
 Report
   > Merging 
[#2888](https://codecov.io/gh/apache/incubator-gobblin/pull/2888?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/3712ec5958d803b8f1a726ab91154f92b0a158a8?src=pr&el=desc)
 will **increase** coverage by `<.01%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2888/graphs/tree.svg?width=650&token=4MgURJ0bGc&height=150&src=pr)](https://codecov.io/gh/apache/incubator-gobblin/pull/2888?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2888      +/-   ##
   ============================================
   + Coverage     45.72%   45.72%   +<.01%     
   - Complexity     9123     9130       +7     
   ============================================
     Files          1926     1926              
     Lines         72527    72563      +36     
     Branches       7983     7993      +10     
   ============================================
   + Hits          33164    33182      +18     
   - Misses        36336    36347      +11     
   - Partials       3027     3034       +7
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2888?src=pr&el=tree) 
| Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...bblin/cluster/GobblinClusterConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2888/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJDb25maWd1cmF0aW9uS2V5cy5qYXZh)
 | `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2888/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
 | `65.5% <100%> (+0.15%)` | `29 <0> (ø)` | :arrow_down: |
   | 
[.../apache/gobblin/cluster/GobblinClusterManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2888/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJNYW5hZ2VyLmphdmE=)
 | `54.95% <100%> (+0.2%)` | `28 <0> (ø)` | :arrow_down: |
   | 
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2888/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
 | `38.93% <100%> (+3.42%)` | `14 <2> (+2)` | :arrow_up: |
   | 
[...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2888/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh)
 | `40% <0%> (-20%)` | `2% <0%> (-1%)` | |
   | 
[...obblin/service/modules/flowgraph/BaseDataNode.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2888/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvQmFzZURhdGFOb2RlLmphdmE=)
 | `66.66% <0%> (-8.34%)` | `5% <0%> (ø)` | |
   | 
[...modules/flowgraph/datanodes/hive/HiveDataNode.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2888/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvZGF0YW5vZGVzL2hpdmUvSGl2ZURhdGFOb2RlLmphdmE=)
 | `63.15% <0%> (-7.44%)` | `4% <0%> (ø)` | |
   | 
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2888/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
 | `85.71% <0%> (-7.15%)` | `3% <0%> (-1%)` | |
   | 
[...hive/entities/TableLikeStageableTableMetadata.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2888/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvbnZlcnNpb24vaGl2ZS9lbnRpdGllcy9UYWJsZUxpa2VTdGFnZWFibGVUYWJsZU1ldGFkYXRhLmphdmE=)
 | `40% <0%> (-6.16%)` | `2% <0%> (ø)` | |
   | 
[...vice/modules/flowgraph/datanodes/HttpDataNode.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2888/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvZGF0YW5vZGVzL0h0dHBEYXRhTm9kZS5qYXZh)
 | `35.71% <0%> (-5.96%)` | `1% <0%> (ø)` | |
   | ... and [11 
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2888/diff?src=pr&el=tree-more)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2888?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2888?src=pr&el=footer).
 Last update 
[3712ec5...be55b72](https://codecov.io/gh/apache/incubator-gobblin/pull/2888?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 386285)
    Time Spent: 50m  (was: 40m)

> Provide an option to pass and set System properties via Gobblin Cluster 
> application config
> ------------------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-1048
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1048
>             Project: Apache Gobblin
>          Issue Type: Improvement
>          Components: gobblin-cluster
>    Affects Versions: 0.15.0
>            Reporter: Sudarshan Vasudevan
>            Assignee: Hung Tran
>            Priority: Major
>             Fix For: 0.15.0
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Helix accesses and sets ZK config overrides (e.g. ZK client session timeout) 
> via Java System properties. This task provides an ability to pass system 
> overrides via Gobblin Cluster application configuration and sets these 
> overrides in the cluster manager and task runners.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to