[jira] [Work logged] (GOBBLIN-1049) Move workunit commit logic to the end of publish().

Thu, 13 Feb 2020 14:12:15 -0800 


     [ 
https://issues.apache.org/jira/browse/GOBBLIN-1049?focusedWorklogId=386909&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-386909
 ]

ASF GitHub Bot logged work on GOBBLIN-1049:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 13/Feb/20 22:11
            Start Date: 13/Feb/20 22:11
    Worklog Time Spent: 10m 
      Work Description: codecov-io commented on issue #2889: [GOBBLIN-1049] 
Move workunit commit logic to the end of publish().
URL: 
https://github.com/apache/incubator-gobblin/pull/2889#issuecomment-585997030
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2889?src=pr&el=h1)
 Report
   > Merging 
[#2889](https://codecov.io/gh/apache/incubator-gobblin/pull/2889?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/10f593223902aaed18d045095e812a2e04da04db?src=pr&el=desc)
 will **decrease** coverage by `<.01%`.
   > The diff coverage is `0%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2889/graphs/tree.svg?width=650&token=4MgURJ0bGc&height=150&src=pr)](https://codecov.io/gh/apache/incubator-gobblin/pull/2889?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2889      +/-   ##
   ============================================
   - Coverage     45.72%   45.72%   -0.01%     
   - Complexity     9129     9131       +2     
   ============================================
     Files          1926     1926              
     Lines         72563    72566       +3     
     Branches       7993     7993              
   ============================================
   + Hits          33180    33181       +1     
   - Misses        36348    36350       +2     
     Partials       3035     3035
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2889?src=pr&el=tree) 
| Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[...rg/apache/gobblin/publisher/BaseDataPublisher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2889/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3B1Ymxpc2hlci9CYXNlRGF0YVB1Ymxpc2hlci5qYXZh)
 | `67.74% <ø> (-0.31%)` | `61 <0> (-1)` | |
   | 
[...va/org/apache/gobblin/publisher/DataPublisher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2889/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcHVibGlzaGVyL0RhdGFQdWJsaXNoZXIuamF2YQ==)
 | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | 
[.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2889/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=)
 | `79.43% <0%> (-0.94%)` | `24% <0%> (ø)` | |
   | 
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2889/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
 | `65.06% <0%> (+1.31%)` | `29% <0%> (+1%)` | :arrow_up: |
   | 
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2889/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
 | `92.85% <0%> (+7.14%)` | `4% <0%> (+1%)` | :arrow_up: |
   | 
[...a/org/apache/gobblin/util/limiter/NoopLimiter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2889/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvbGltaXRlci9Ob29wTGltaXRlci5qYXZh)
 | `60% <0%> (+20%)` | `3% <0%> (+1%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2889?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2889?src=pr&el=footer).
 Last update 
[10f5932...b46ae94](https://codecov.io/gh/apache/incubator-gobblin/pull/2889?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 386909)
    Time Spent: 20m  (was: 10m)

> Move workunit commit logic to the end of publish().
> ---------------------------------------------------
>
>                 Key: GOBBLIN-1049
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1049
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Kuai Yu
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> We should not blindly commit workunit in the BaseDataPublisher.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to