[
https://issues.apache.org/jira/browse/GOBBLIN-1051?focusedWorklogId=387750&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-387750
]
ASF GitHub Bot logged work on GOBBLIN-1051:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Feb/20 23:54
Start Date: 14/Feb/20 23:54
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2891: [GOBBLIN-1051]
Emit Helix Leader Metrics
URL:
https://github.com/apache/incubator-gobblin/pull/2891#issuecomment-586523868
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2891?src=pr&el=h1)
Report
> Merging
[#2891](https://codecov.io/gh/apache/incubator-gobblin/pull/2891?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/0b059870755bbab93f11d1cf620862e7502b2d4c?src=pr&el=desc)
will **increase** coverage by `1.04%`.
> The diff coverage is `82.6%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2891?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2891 +/- ##
============================================
+ Coverage 44.78% 45.82% +1.04%
- Complexity 8958 9146 +188
============================================
Files 1926 1929 +3
Lines 72555 72625 +70
Branches 7992 7997 +5
============================================
+ Hits 32491 33279 +788
+ Misses 37073 36306 -767
- Partials 2991 3040 +49
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2891?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...org/apache/gobblin/metrics/ServiceMetricNames.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvU2VydmljZU1ldHJpY05hbWVzLmphdmE=)
| `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...in/service/modules/core/GobblinServiceManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9jb3JlL0dvYmJsaW5TZXJ2aWNlTWFuYWdlci5qYXZh)
| `56.94% <82.6%> (+2.22%)` | `25 <0> (ø)` | :arrow_down: |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `85.71% <0%> (-7.15%)` | `3% <0%> (ø)` | |
|
[...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=)
| `70% <0%> (-2.23%)` | `13% <0%> (ø)` | |
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `38.93% <0%> (-0.32%)` | `14% <0%> (+1%)` | |
|
[...rg/apache/gobblin/publisher/BaseDataPublisher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3B1Ymxpc2hlci9CYXNlRGF0YVB1Ymxpc2hlci5qYXZh)
| `67.74% <0%> (-0.31%)` | `61% <0%> (-1%)` | |
|
[...ava/org/apache/gobblin/metrics/GobblinMetrics.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL21ldHJpY3MvR29iYmxpbk1ldHJpY3MuamF2YQ==)
| `18.8% <0%> (-0.06%)` | `15% <0%> (ø)` | |
|
[...va/org/apache/gobblin/publisher/DataPublisher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr&el=tree#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcHVibGlzaGVyL0RhdGFQdWJsaXNoZXIuamF2YQ==)
| `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
|
[...a/org/apache/gobblin/runtime/util/ForkMetrics.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvdXRpbC9Gb3JrTWV0cmljcy5qYXZh)
| `100% <0%> (ø)` | `5% <0%> (-1%)` | :arrow_down: |
|
[...ache/gobblin/cluster/InMemorySingleTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSW5NZW1vcnlTaW5nbGVUYXNrUnVubmVyLmphdmE=)
| `100% <0%> (ø)` | `3% <0%> (?)` | |
| ... and [50
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2891/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2891?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2891?src=pr&el=footer).
Last update
[0b05987...d81409a](https://codecov.io/gh/apache/incubator-gobblin/pull/2891?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 387750)
Remaining Estimate: 0h
Time Spent: 10m
> Emit helix leader metrics to ingraph
> -------------------------------------
>
> Key: GOBBLIN-1051
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1051
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Wei-Hsiang Lin
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
