amarnathkarthik commented on a change in pull request #2633: GOBBLIN-759: Added
feature to support DistCP to copy files that were …
URL: https://github.com/apache/incubator-gobblin/pull/2633#discussion_r379849293
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/policy/SelectBetweenTimeBasedPolicy.java
##########
@@ -94,17 +100,25 @@ public SelectBetweenTimeBasedPolicy(Optional<Period>
minLookBackPeriod, Optional
public boolean apply(TimestampedDatasetVersion version) {
return version.getDateTime()
.plus(SelectBetweenTimeBasedPolicy.this.maxLookBackPeriod.or(new
Period(DateTime.now().getMillis())))
- .isAfterNow()
- &&
version.getDateTime().plus(SelectBetweenTimeBasedPolicy.this.minLookBackPeriod.or(new
Period(0)))
- .isBeforeNow();
+ .isAfterNow() && version.getDateTime()
+ .plus(SelectBetweenTimeBasedPolicy.this.minLookBackPeriod.or(new
Period(0)))
+ .isBeforeNow();
}
};
}
protected static Period getLookBackPeriod(String lookbackTime) {
Review comment:
For better readability, prefer to have this reformatting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
