sv2000 commented on a change in pull request #2891: [GOBBLIN-1051] Emit Helix
Leader Metrics
URL: https://github.com/apache/incubator-gobblin/pull/2891#discussion_r380895329
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GobblinServiceManager.java
##########
@@ -214,6 +223,14 @@ public GobblinServiceManager(String serviceName, String
serviceId, Config config
this.isGitConfigMonitorEnabled = false;
}
+ // Initialize Helix leader guage
+ helixLeaderGauges = Optional.of(new HelixLeaderState());
+ String helixLeaderStateGaugeName =
+ MetricRegistry.name(MetricReportUtils.GOBBLIN_SERVICE_METRICS_PREFIX,
ServiceMetricNames.HELIX_LEADER_STATE);
+ ContextAwareGauge<Integer> gauge =
metricContext.newContextAwareGauge(helixLeaderStateGaugeName, () ->
helixLeaderGauges.get().state.value);
Review comment:
Use helixLeaderGauges.get().state.getValue() with Getter on value field?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
