[
https://issues.apache.org/jira/browse/GOBBLIN-1056?focusedWorklogId=390353&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-390353
]
ASF GitHub Bot logged work on GOBBLIN-1056:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Feb/20 01:04
Start Date: 21/Feb/20 01:04
Worklog Time Spent: 10m
Work Description: zxcware commented on pull request #2896: [GOBBLIN-1056]
Refactor to allow customizing client pool population in KafkaSource
URL: https://github.com/apache/incubator-gobblin/pull/2896
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title.
- https://issues.apache.org/jira/browse/GOBBLIN-1056
### Description
- [x] Here are some details about my PR:
- A very little refactor of `KafkaSource` to allow customizing how to
populate the client pool.
### Tests
- [x] My PR does not need testing for this reason:
- The change is simply moving some lines into a method
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 390353)
Remaining Estimate: 0h
Time Spent: 10m
> Allow customizing client pool population in KafkaSource
> -------------------------------------------------------
>
> Key: GOBBLIN-1056
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1056
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zhixiong Chen
> Assignee: Zhixiong Chen
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Put existing logic of consumer client pool population into method
> `populateClientPool`, it allows the client created for the pool to carry
> additional information from the client created to fetch topics
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
