[
https://issues.apache.org/jira/browse/GOBBLIN-1052?focusedWorklogId=391018&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-391018
]
ASF GitHub Bot logged work on GOBBLIN-1052:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/Feb/20 01:54
Start Date: 22/Feb/20 01:54
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2892:
GOBBLIN-1052: Create a spec consumer path if it does not exist in FS …
URL: https://github.com/apache/incubator-gobblin/pull/2892#discussion_r382875236
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/HelixUtils.java
##########
@@ -293,6 +294,10 @@ private static void deleteStoppedHelixJob(HelixManager
helixManager, String work
Map<String, WorkflowConfig> workflowConfigMap = taskDriver.getWorkflows();
for (String workflow : workflowConfigMap.keySet()) {
WorkflowConfig workflowConfig = taskDriver.getWorkflowConfig(workflow);
+ //Filter out any stale Helix workflows which are not running.
+ if (workflowConfig.getTargetState() != TargetState.START) {
Review comment:
Why filter out stopped job if the method call is to get a list of workFlowId
from Gobblin job name ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 391018)
Time Spent: 0.5h (was: 20m)
> Create a spec consumer path if it does not exist in FS SpecConsumer
> -------------------------------------------------------------------
>
> Key: GOBBLIN-1052
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1052
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-cluster
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Hung Tran
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Current implementation expects the spec consumer path to already exist.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
