[
https://issues.apache.org/jira/browse/GOBBLIN-1057?focusedWorklogId=392127&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-392127
]
ASF GitHub Bot logged work on GOBBLIN-1057:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Feb/20 22:28
Start Date: 24/Feb/20 22:28
Worklog Time Spent: 10m
Work Description: htran1 commented on pull request #2897: [GOBBLIN-1057]
Remove unnecessary RPCs in distcp-ng
URL: https://github.com/apache/incubator-gobblin/pull/2897
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [X] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1057
### Description
- [X] Here are some details about my PR, including screenshots (if
applicable):
Disable fetching of the source checksum by default.
There is no code using it, so this should not have any impact.
If the DataFileVersionStrategy is ModTimeDataFileVersionStrategy then
optimize the code path by using the modification time in the FileStatus
object that has already been fetched.
### Tests
- [X] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
Ran existing tests.
### Commits
- [X] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 392127)
Remaining Estimate: 0h
Time Spent: 10m
> Optimize unnecessary RPCs in distcp-ng
> --------------------------------------
>
> Key: GOBBLIN-1057
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1057
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Hung Tran
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> There are some per-file FileSystem RPCs being invoked in Gobblin distcp-ng.
> This results in a long file discovery phase that can be hours for a few
> thousand files.
> The RPCs that can be removed are:
> getFileChecksum() - the value doesn't appear to be used.
> getFileStatus() - this is called to get the modification time in
> ModTimeDataFileVersionStrategy.getVersion(). The modification time is already
> available from listStatus(), so use that value.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
