[
https://issues.apache.org/jira/browse/GOBBLIN-1057?focusedWorklogId=392174&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-392174
]
ASF GitHub Bot logged work on GOBBLIN-1057:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Feb/20 23:19
Start Date: 24/Feb/20 23:19
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2897: [GOBBLIN-1057]
Remove unnecessary RPCs in distcp-ng
URL:
https://github.com/apache/incubator-gobblin/pull/2897#issuecomment-590596708
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2897?src=pr&el=h1)
Report
> Merging
[#2897](https://codecov.io/gh/apache/incubator-gobblin/pull/2897?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/096fc0c78f820df26958f22b53558ca4b082f7ce?src=pr&el=desc)
will **increase** coverage by `<.01%`.
> The diff coverage is `38.46%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2897?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2897 +/- ##
============================================
+ Coverage 45.77% 45.77% +<.01%
- Complexity 9152 9156 +4
============================================
Files 1932 1932
Lines 72768 72777 +9
Branches 8013 8021 +8
============================================
+ Hits 33307 33313 +6
+ Misses 36418 36413 -5
- Partials 3043 3051 +8
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2897?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...che/gobblin/data/management/copy/CopyableFile.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2897/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvQ29weWFibGVGaWxlLmphdmE=)
| `81.39% <100%> (+0.21%)` | `33 <1> (+1)` | :arrow_up: |
|
[...ata/management/copy/hive/HiveCopyEntityHelper.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2897/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaGl2ZS9IaXZlQ29weUVudGl0eUhlbHBlci5qYXZh)
| `22.6% <33.33%> (-0.27%)` | `14 <0> (ø)` | |
|
[...anagement/copy/replication/ConfigBasedDataset.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2897/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvcmVwbGljYXRpb24vQ29uZmlnQmFzZWREYXRhc2V0LmphdmE=)
| `68.66% <33.33%> (-1.89%)` | `10 <0> (ø)` | |
|
[...lin/util/filesystem/FileSystemInstrumentation.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2897/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvZmlsZXN5c3RlbS9GaWxlU3lzdGVtSW5zdHJ1bWVudGF0aW9uLmphdmE=)
| `85.71% <0%> (-7.15%)` | `3% <0%> (ø)` | |
|
[...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2897/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=)
| `70% <0%> (-2.23%)` | `13% <0%> (ø)` | |
|
[...main/java/org/apache/gobblin/util/HadoopUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2897/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvSGFkb29wVXRpbHMuamF2YQ==)
| `30.2% <0%> (-0.68%)` | `24% <0%> (-1%)` | |
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2897/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `65.5% <0%> (+0.43%)` | `29% <0%> (ø)` | :arrow_down: |
|
[...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2897/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=)
| `64.44% <0%> (+1.11%)` | `16% <0%> (+1%)` | :arrow_up: |
|
[...obblin/data/management/copy/CopyConfiguration.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2897/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvQ29weUNvbmZpZ3VyYXRpb24uamF2YQ==)
| `85% <0%> (+5%)` | `14% <0%> (+1%)` | :arrow_up: |
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2897/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `41.73% <0%> (+6.08%)` | `15% <0%> (+2%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2897?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2897?src=pr&el=footer).
Last update
[096fc0c...86b4228](https://codecov.io/gh/apache/incubator-gobblin/pull/2897?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 392174)
Time Spent: 50m (was: 40m)
> Remove unnecessary RPCs in distcp-ng
> ------------------------------------
>
> Key: GOBBLIN-1057
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1057
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Hung Tran
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> There are some per-file FileSystem RPCs being invoked in Gobblin distcp-ng.
> This results in a long file discovery phase that can be hours for a few
> thousand files.
> The RPCs that can be removed are:
> getFileChecksum() - the value doesn't appear to be used.
> getFileStatus() - this is called to get the modification time in
> ModTimeDataFileVersionStrategy.getVersion(). The modification time is already
> available from listStatus(), so use that value.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
