[ 
https://issues.apache.org/jira/browse/GOBBLIN-1060?focusedWorklogId=392932&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-392932
 ]

ASF GitHub Bot logged work on GOBBLIN-1060:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Feb/20 21:11
            Start Date: 25/Feb/20 21:11
    Worklog Time Spent: 10m 
      Work Description: sv2000 commented on pull request #2899: 
[GOBBLIN-1060]Fix wrong fileSystem object in YarnApplauncher
URL: https://github.com/apache/incubator-gobblin/pull/2899#discussion_r384128391
 
 

 ##########
 File path: 
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java
 ##########
 @@ -608,21 +608,22 @@ private Resource 
prepareContainerResource(GetNewApplicationResponse newApplicati
     Path appMasterWorkDir = new Path(appWorkDir, 
GobblinYarnConfigurationKeys.APP_MASTER_WORK_DIR_NAME);
 
     Map<String, LocalResource> appMasterResources = Maps.newHashMap();
+    FileSystem localFs = FileSystem.getLocal(this.yarnConfiguration);
 
 Review comment:
   Maybe it is safer to use FileSystem.getLocal(new Configuration()) since we 
are dependent of fs.defaultFS not being configured in yarnConfiguration. 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 392932)
    Time Spent: 0.5h  (was: 20m)

> Fix YarnAppLauncher resource existence checking with wrong fs object
> --------------------------------------------------------------------
>
>                 Key: GOBBLIN-1060
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1060
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Lei Sun
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to