[
https://issues.apache.org/jira/browse/GOBBLIN-1066?focusedWorklogId=395373&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-395373
]
ASF GitHub Bot logged work on GOBBLIN-1066:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 29/Feb/20 01:45
Start Date: 29/Feb/20 01:45
Worklog Time Spent: 10m
Work Description: zxcware commented on pull request #2904: [GOBBLIN-1066]
field projection with namespace
URL: https://github.com/apache/incubator-gobblin/pull/2904
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title.
- https://issues.apache.org/jira/browse/GOBBLIN-1066
### Description
- [x] Here are some details about my PR:
- `AvroProjectionConverter` currently ignores extract namespace to identify
fields to remove for a table. The change is to identify fields to remove with
namespace into account, configurable.
### Tests
- [x] My PR adds the following unit tests:
- `AvroProjectionConverterTest.testRemoveWithNamespace` verifies that fields
are only removed if key `<namespace>.<table name>.remove.fields`, which is
`db1.table1.remove.fields` in this test, is present.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 395373)
Remaining Estimate: 0h
Time Spent: 10m
> field projection with namespace
> -------------------------------
>
> Key: GOBBLIN-1066
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1066
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zhixiong Chen
> Assignee: Zhixiong Chen
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> `AvroProjectionConverter` currently ignores extract namespace to identify
> fields to remove for a table. The change is to identify fields to remove with
> namespace into account, configurable.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
