sv2000 commented on a change in pull request #2900: [GOBBLIN-1040]
HighLevelConsumer re-design by removing references to …
URL: https://github.com/apache/incubator-gobblin/pull/2900#discussion_r386166631
##########
File path:
gobblin-modules/gobblin-kafka-09/src/main/java/org/apache/gobblin/kafka/client/Kafka09ConsumerClient.java
##########
@@ -180,6 +200,26 @@ public KafkaConsumerRecord apply(ConsumerRecord<K, V>
input) {
return codaHaleMetricMap;
}
+ @Override
+ public synchronized void commitOffsets(Map<KafkaPartition, Long>
partitionOffsets) {
Review comment:
Add javadoc since it is a public API. Also, it would be good to have both
sync and async commit options here. commitSync would essentially reduce the
window of double consumption, if an implementation cares about it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
