sv2000 commented on a change in pull request #2900: [GOBBLIN-1040]
HighLevelConsumer re-design by removing references to …
URL: https://github.com/apache/incubator-gobblin/pull/2900#discussion_r386164499
##########
File path:
gobblin-modules/gobblin-kafka-08/src/main/java/org/apache/gobblin/kafka/client/Kafka08ConsumerClient.java
##########
@@ -345,8 +350,8 @@ public GobblinKafkaConsumerClient create(Config config) {
private final MessageAndOffset messageAndOffset;
- public Kafka08ConsumerRecord(MessageAndOffset messageAndOffset) {
- super(messageAndOffset.offset(), messageAndOffset.message().size());
+ public Kafka08ConsumerRecord(MessageAndOffset messageAndOffset, int
partition, String topic) {
Review comment:
can we change the argument order to first have topic and then partition to
be consistent with other APIs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
