[
https://issues.apache.org/jira/browse/GOBBLIN-1040?focusedWorklogId=395742&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-395742
]
ASF GitHub Bot logged work on GOBBLIN-1040:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Mar/20 02:42
Start Date: 02/Mar/20 02:42
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2900: [GOBBLIN-1040]
HighLevelConsumer re-design by removing references to …
URL: https://github.com/apache/incubator-gobblin/pull/2900#discussion_r386174145
##########
File path:
gobblin-runtime/src/test/java/org/apache/gobblin/runtime/job_monitor/KafkaJobMonitorTest.java
##########
@@ -18,42 +18,85 @@
package org.apache.gobblin.runtime.job_monitor;
import java.net.URI;
+import java.util.Properties;
+import org.apache.kafka.clients.consumer.ConsumerRecord;
+import org.mockito.Mockito;
import org.testng.Assert;
+import org.testng.annotations.AfterSuite;
+import org.testng.annotations.BeforeSuite;
import org.testng.annotations.Test;
-import com.google.common.base.Optional;
-import com.typesafe.config.Config;
+import com.google.common.base.Charsets;
+import com.google.common.io.Closer;
-import org.apache.gobblin.runtime.kafka.HighLevelConsumerTest;
+import org.apache.gobblin.configuration.ConfigurationKeys;
+import org.apache.gobblin.kafka.KafkaTestBase;
+import org.apache.gobblin.kafka.client.Kafka09ConsumerClient;
+import org.apache.gobblin.kafka.client.KafkaConsumerRecord;
+import org.apache.gobblin.kafka.writer.Kafka09DataWriter;
+import org.apache.gobblin.kafka.writer.KafkaWriterConfigurationKeys;
+import org.apache.gobblin.util.ConfigUtils;
+import org.apache.gobblin.writer.AsyncDataWriter;
+import org.apache.gobblin.writer.WriteCallback;
-public class KafkaJobMonitorTest {
+public class KafkaJobMonitorTest extends KafkaTestBase {
+
+ private static final String TOPIC =
KafkaJobMonitorTest.class.getSimpleName();
+ private static final int NUM_PARTITIONS = 2;
+
+ private Closer _closer;
+ private String _kafkaBrokers;
+ private AsyncDataWriter dataWriter;
+
+ public KafkaJobMonitorTest()
+ throws InterruptedException, RuntimeException {
+ super();
+ _kafkaBrokers = "localhost:" + this.getKafkaServerPort();
+ }
+
+ @BeforeSuite
+ public void beforeSuite() throws Exception {
+ startServers();
+ _closer = Closer.create();
+ Properties producerProps = new Properties();
+ producerProps.setProperty(KafkaWriterConfigurationKeys.KAFKA_TOPIC, TOPIC);
+
producerProps.setProperty(KafkaWriterConfigurationKeys.KAFKA_PRODUCER_CONFIG_PREFIX
+ "bootstrap.servers", _kafkaBrokers);
Review comment:
Define bootstrap.servers config as a static variable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 395742)
Time Spent: 2h 50m (was: 2h 40m)
> Fix High level consumer
> ------------------------
>
> Key: GOBBLIN-1040
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1040
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Vikram Bohra
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
