[
https://issues.apache.org/jira/browse/GOBBLIN-1067?focusedWorklogId=396906&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-396906
]
ASF GitHub Bot logged work on GOBBLIN-1067:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Mar/20 18:21
Start Date: 03/Mar/20 18:21
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2906: GOBBLIN-1067: Add
SFTP DataNode type in Gobblin-as-a-Service (GaaS) F…
URL:
https://github.com/apache/incubator-gobblin/pull/2906#issuecomment-594094962
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2906?src=pr&el=h1)
Report
> Merging
[#2906](https://codecov.io/gh/apache/incubator-gobblin/pull/2906?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/0de109b6941e636f4a35069752ef1e3c4188054d?src=pr&el=desc)
will **increase** coverage by `<.01%`.
> The diff coverage is `85%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2906?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2906 +/- ##
============================================
+ Coverage 45.86% 45.86% +<.01%
- Complexity 9170 9188 +18
============================================
Files 1932 1934 +2
Lines 72789 72856 +67
Branches 8022 8032 +10
============================================
+ Hits 33386 33418 +32
- Misses 36342 36374 +32
- Partials 3061 3064 +3
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2906?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...e/modules/flowgraph/datanodes/fs/SftpDataNode.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9mbG93Z3JhcGgvZGF0YW5vZGVzL2ZzL1NmdHBEYXRhTm9kZS5qYXZh)
| `85% <85%> (ø)` | `7 <7> (?)` | |
|
[.../hive/filter/LookbackPartitionFilterGenerator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L2NvcHkvaGl2ZS9maWx0ZXIvTG9va2JhY2tQYXJ0aXRpb25GaWx0ZXJHZW5lcmF0b3IuamF2YQ==)
| `78.94% <0%> (-21.06%)` | `6% <0%> (+3%)` | |
|
[...re/ControllerUserDefinedMessageHandlerFactory.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9jb3JlL0NvbnRyb2xsZXJVc2VyRGVmaW5lZE1lc3NhZ2VIYW5kbGVyRmFjdG9yeS5qYXZh)
| `39.06% <0%> (-12.5%)` | `4% <0%> (ø)` | |
|
[...estli/GobblinServiceFlowConfigResourceHandler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9yZXN0bGkvR29iYmxpblNlcnZpY2VGbG93Q29uZmlnUmVzb3VyY2VIYW5kbGVyLmphdmE=)
| `44.61% <0%> (-6.16%)` | `10% <0%> (-1%)` | |
|
[.../modules/scheduler/GobblinServiceJobScheduler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9zY2hlZHVsZXIvR29iYmxpblNlcnZpY2VKb2JTY2hlZHVsZXIuamF2YQ==)
| `53.71% <0%> (-4.58%)` | `19% <0%> (-2%)` | |
|
[...e/gobblin/runtime/locks/ZookeeperBasedJobLock.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvbG9ja3MvWm9va2VlcGVyQmFzZWRKb2JMb2NrLmphdmE=)
| `63.33% <0%> (-1.12%)` | `15% <0%> (-1%)` | |
|
[...rg/apache/gobblin/yarn/GobblinYarnAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5BcHBMYXVuY2hlci5qYXZh)
| `21.02% <0%> (-0.16%)` | `8% <0%> (ø)` | |
|
[...blin/service/modules/orchestration/DagManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9kdWxlcy9vcmNoZXN0cmF0aW9uL0RhZ01hbmFnZXIuamF2YQ==)
| `76.47% <0%> (-0.08%)` | `13% <0%> (ø)` | |
|
[...ain/java/org/apache/gobblin/runtime/fork/Fork.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvZm9yay9Gb3JrLmphdmE=)
| `75% <0%> (ø)` | `68% <0%> (ø)` | :arrow_down: |
|
[.../apache/gobblin/service/FlowConfigsV2Resource.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnc1YyUmVzb3VyY2UuamF2YQ==)
| `0% <0%> (ø)` | `0% <0%> (ø)` | :arrow_down: |
| ... and [10
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2906/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2906?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2906?src=pr&el=footer).
Last update
[0de109b...ca334c8](https://codecov.io/gh/apache/incubator-gobblin/pull/2906?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 396906)
Time Spent: 0.5h (was: 20m)
> Add SFTP DataNode type in Gobblin-as-a-Service (GaaS) FlowGraph
> ----------------------------------------------------------------
>
> Key: GOBBLIN-1067
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1067
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-service
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Abhishek Tiwari
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> This PR adds a new DataNode type in GaaS FlowGraph. This will allow GaaS'
> MultiHop flow compiler to orchetrate jobs pulling/pushing data from/to SFTP
> source/sinks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
