arekusuri opened a new pull request #2910: Add typed config in salesforce URL: https://github.com/apache/incubator-gobblin/pull/2910 Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA ### Description replace `properties.get()` with typed class field `config.bulkApiUseQueryAll`. It would be neater/readable and any typo can be find out at compiling time. > - workUnitState.getPropAsBoolean(BULK_API_USE_QUERY_ALL, DEFAULT_BULK_API_USE_QUERY_ALL); > + this.bulkApiUseQueryAll = conf.bulkApiUseQueryAll; ### Tests https://ltx1-holdemaz05.grid.linkedin.com:8443/executor?execid=23983645&job=salesforce_task_full&attempt=0
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
