vikrambohra commented on a change in pull request #2900: [GOBBLIN-1040]
HighLevelConsumer re-design by removing references to …
URL: https://github.com/apache/incubator-gobblin/pull/2900#discussion_r388688470
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/kafka/HighLevelConsumer.java
##########
@@ -221,6 +228,9 @@ public void run() {
private void consume() {
try {
Iterator<KafkaConsumerRecord> itr = gobblinKafkaConsumerClient.consume();
+ if(!enableAutoCommit) {
Review comment:
I don't think it really makes a difference because both adding messages to
the queue and offset commiting are async operations. But it will make sense to
keep it here if we ever decide to commit synchronously. In that case we are
making sure we are committing the previous offsets and not the ones from the
current consume() call
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
