[
https://issues.apache.org/jira/browse/GOBBLIN-1040?focusedWorklogId=398890&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-398890
]
ASF GitHub Bot logged work on GOBBLIN-1040:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Mar/20 03:27
Start Date: 06/Mar/20 03:27
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2900: [GOBBLIN-1040]
HighLevelConsumer re-design by removing references to …
URL:
https://github.com/apache/incubator-gobblin/pull/2900#issuecomment-594995701
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2900?src=pr&el=h1)
Report
> Merging
[#2900](https://codecov.io/gh/apache/incubator-gobblin/pull/2900?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/dec3b91abb6ab3dc7223eaa3b19124cfe3c1d922?src=pr&el=desc)
will **decrease** coverage by `0.41%`.
> The diff coverage is `10.48%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2900?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2900 +/- ##
============================================
- Coverage 45.86% 45.44% -0.42%
+ Complexity 9187 9106 -81
============================================
Files 1934 1936 +2
Lines 72856 72974 +118
Branches 8032 8035 +3
============================================
- Hits 33412 33160 -252
- Misses 36380 36762 +382
+ Partials 3064 3052 -12
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2900?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[...untime/job\_monitor/AvroJobSpecKafkaJobMonitor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2900/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvQXZyb0pvYlNwZWNLYWZrYUpvYk1vbml0b3IuamF2YQ==)
| `0% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...pache/gobblin/service/AvroJobSpecDeserializer.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2900/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtMDgvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9BdnJvSm9iU3BlY0Rlc2VyaWFsaXplci5qYXZh)
| `0% <ø> (ø)` | `0 <0> (?)` | |
|
[...lin/kafka/writer/KafkaWriterConfigurationKeys.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2900/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL3dyaXRlci9LYWZrYVdyaXRlckNvbmZpZ3VyYXRpb25LZXlzLmphdmE=)
| `66.66% <ø> (ø)` | `1 <0> (ø)` | :arrow_down: |
|
[...bblin/runtime/job\_monitor/KafkaAvroJobMonitor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2900/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvS2Fma2FBdnJvSm9iTW9uaXRvci5qYXZh)
| `0% <ø> (-93.11%)` | `0 <0> (-7)` | |
|
[...ache/gobblin/kafka/client/KafkaConsumerRecord.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2900/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL2NsaWVudC9LYWZrYUNvbnN1bWVyUmVjb3JkLmphdmE=)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[.../gobblin/kafka/client/BaseKafkaConsumerRecord.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2900/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL2NsaWVudC9CYXNlS2Fma2FDb25zdW1lclJlY29yZC5qYXZh)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...bblin/kafka/client/GobblinKafkaConsumerClient.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2900/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2thZmthL2NsaWVudC9Hb2JibGluS2Fma2FDb25zdW1lckNsaWVudC5qYXZh)
| `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
|
[...blin/service/monitoring/KafkaJobStatusMonitor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2900/diff?src=pr&el=tree#diff-Z29iYmxpbi1zZXJ2aWNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NlcnZpY2UvbW9uaXRvcmluZy9LYWZrYUpvYlN0YXR1c01vbml0b3IuamF2YQ==)
| `0% <0%> (-72.23%)` | `0 <0> (-16)` | |
|
[...pache/gobblin/service/AvroJobSpecDeserializer.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2900/diff?src=pr&el=tree#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4ta2Fma2EtMDkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9BdnJvSm9iU3BlY0Rlc2VyaWFsaXplci5qYXZh)
| `0% <0%> (ø)` | `0 <0> (?)` | |
|
[...e/gobblin/runtime/job\_monitor/KafkaJobMonitor.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2900/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvam9iX21vbml0b3IvS2Fma2FKb2JNb25pdG9yLmphdmE=)
| `0% <0%> (-65.22%)` | `0 <0> (-9)` | |
| ... and [21
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2900/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2900?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2900?src=pr&el=footer).
Last update
[dec3b91...9814900](https://codecov.io/gh/apache/incubator-gobblin/pull/2900?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 398890)
Time Spent: 5h 10m (was: 5h)
> Fix High level consumer
> ------------------------
>
> Key: GOBBLIN-1040
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1040
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Vikram Bohra
> Priority: Major
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> Redesign High Level Consumer to achieve the following
> * Remove direct dependencies to deprecated open source Kafka and replace
> with Gobblin abstractions of Kafka.
> * Make the High level consumer robust by providing at least once delivery by
> recording and manually committing offsets
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
