sv2000 commented on a change in pull request #2912: [GOBBLIN-1072] Being more
conservative on leasing containers
URL: https://github.com/apache/incubator-gobblin/pull/2912#discussion_r389195341
##########
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnAutoScalingManager.java
##########
@@ -189,16 +224,123 @@ void runInternal() {
}
}
+ // Find all participants appearing in this cluster. Note that Helix
instances can contain cluster-manager
+ // and potentially replanner-instance.
+ Set<String> allParticipants =
getParticipants(GobblinYarnTaskRunner.class.getSimpleName());
Review comment:
Can we define a static variable HELIX_INSTANCE_NAME_PREFIX =
GobblinYarnTaskRunner.class.getSimpleName() in YarnService and use it in
onContainersAllocated as well as here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
