[
https://issues.apache.org/jira/browse/GOBBLIN-1072?focusedWorklogId=399416&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-399416
]
ASF GitHub Bot logged work on GOBBLIN-1072:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Mar/20 23:14
Start Date: 06/Mar/20 23:14
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2912:
[GOBBLIN-1072] Add sliding window to protect AutoScaling from fluctuation of
number of active Helix partitions
URL: https://github.com/apache/incubator-gobblin/pull/2912#discussion_r389188549
##########
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/YarnAutoScalingManager.java
##########
@@ -196,9 +207,84 @@ void runInternal() {
// adjust the number of target containers based on the configured min
and max container values.
numTargetContainers = Math.max(this.minContainers,
Math.min(this.maxContainers, numTargetContainers));
+ slidingFixedWindow.add(numTargetContainers);
Review comment:
Discussed offline. Agreed on new way to tag an instance as "unused" and be
more conservative on container release.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 399416)
Time Spent: 0.5h (was: 20m)
> Being more conservative on releasing YARN containers
> ----------------------------------------------------
>
> Key: GOBBLIN-1072
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1072
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
