amarnathkarthik commented on a change in pull request #2633: GOBBLIN-759: Added feature to support DistCP to copy files that were … URL: https://github.com/apache/incubator-gobblin/pull/2633#discussion_r389482730
########## File path: gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/TimestampBasedCopyableDataset.java ########## @@ -73,6 +71,7 @@ private final VersionSelectionPolicy<TimestampedDatasetVersion> versionSelectionPolicy; private final ExecutorService executor; private final FileSystem srcFs; + private final CopyableFileFilter copyableFileFilter; Review comment: Thanks for the reference. AndPathFilter and CopyableFileFilter are two different interfaces and did not find a way to merge. AndPathFilter implements accept(..) whereas CopyableFileFilter implements filter(..). Please advise. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
