autumnust commented on a change in pull request #2916: GOBBLIN-1076: Make Gobblin cluster working directories configurable URL: https://github.com/apache/incubator-gobblin/pull/2916#discussion_r390549954
########## File path: gobblin-cluster/src/main/java/org/apache/gobblin/cluster/GobblinTaskRunner.java ########## @@ -113,6 +107,9 @@ */ @Alpha public class GobblinTaskRunner implements StandardMetricsBridge { + // Working directory key for applications. This config is set dynamically. + public static final String CLUSTER_APP_WORK_DIR = GobblinClusterConfigurationKeys.GOBBLIN_CLUSTER_PREFIX + "appWorkDir"; Review comment: If set dynamically, shall make it package private instead of globally accessible ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services