[ https://issues.apache.org/jira/browse/GOBBLIN-1079?focusedWorklogId=401024&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-401024 ]
ASF GitHub Bot logged work on GOBBLIN-1079: ------------------------------------------- Author: ASF GitHub Bot Created on: 10/Mar/20 22:35 Start Date: 10/Mar/20 22:35 Worklog Time Spent: 10m Work Description: arjun4084346 commented on pull request #2918: [GOBBLIN-1079] set extract.is.full property URL: https://github.com/apache/incubator-gobblin/pull/2918 Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! @yukuai518 please review ### JIRA - [x] My PR addresses the following [Gobblin-1079](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. ### Description - [x] Here are some details about my PR, including screenshots (if applicable): a new pull job that pulls from file based source S3 with snapshot_only extract type. But the job is still writing the output as _append instead of _full . this PR will use the appropriate configs so the output path is correctly calculated. ### Tests - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: trivial changes ### Commits - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 401024) Remaining Estimate: 0h Time Spent: 10m > use config extract.is.full > -------------------------- > > Key: GOBBLIN-1079 > URL: https://issues.apache.org/jira/browse/GOBBLIN-1079 > Project: Apache Gobblin > Issue Type: Bug > Reporter: Arjun Singh Bora > Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)