[
https://issues.apache.org/jira/browse/GOBBLIN-1078?focusedWorklogId=401043&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-401043
]
ASF GitHub Bot logged work on GOBBLIN-1078:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Mar/20 23:29
Start Date: 10/Mar/20 23:29
Worklog Time Spent: 10m
Work Description: ZihanLi58 commented on pull request #2919:
[GOBBLIN-1078] Coordination between task cancel and initialization in Helix Task
URL: https://github.com/apache/incubator-gobblin/pull/2919#discussion_r390667869
##########
File path:
gobblin-cluster/src/main/java/org/apache/gobblin/cluster/SingleTask.java
##########
@@ -63,6 +69,12 @@
private Config _dynamicConfig;
private JobState _jobState;
+ // Preventing Helix calling cancel before taskAttempt is created
+ // Checking if taskAttempt is empty is not enough, since canceller runs in
different thread as runner, the case to
+ // to avoided here is taskAttempt being created and start to run after
cancel has been called.
Review comment:
nit: the case to be avoided?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 401043)
Time Spent: 40m (was: 0.5h)
> Coordination between task cancel and task initialization in Helix
> -----------------------------------------------------------------
>
> Key: GOBBLIN-1078
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1078
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
