sv2000 commented on a change in pull request #2913: [GOBBLIN-1073] Add proxy user and requester quota to GaaS URL: https://github.com/apache/incubator-gobblin/pull/2913#discussion_r391186509
########## File path: gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java ########## @@ -362,6 +370,8 @@ public synchronized void setActive(boolean active) { */ public static class DagManagerThread implements Runnable { private final Map<DagNode<JobExecutionPlan>, Dag<JobExecutionPlan>> jobToDag = new HashMap<>(); + private static final Map<String, Integer> proxyUserToJobCount = new ConcurrentHashMap<>(); Review comment: Should this be a global map shared across all threads? IIRC, we use flowName, flowGroup and flowExecutionId to map a given flow execution to a DagManagerThread. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services