[
https://issues.apache.org/jira/browse/GOBBLIN-1080?focusedWorklogId=403167&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403167
]
ASF GitHub Bot logged work on GOBBLIN-1080:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 13/Mar/20 20:48
Start Date: 13/Mar/20 20:48
Worklog Time Spent: 10m
Work Description: autumnust commented on pull request #2925:
[GOBBLIN-1080] Add configuration to add schema creation time in converter
URL: https://github.com/apache/incubator-gobblin/pull/2925#discussion_r392466285
##########
File path:
gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java
##########
@@ -833,6 +835,7 @@
public static final String KAFKA_SCHEMA_REGISTRY_RETRY_TIMES =
"kafka.schema.registry.retry.times";
public static final String KAFKA_SCHEMA_REGISTRY_RETRY_INTERVAL_IN_MILLIS =
"kafka.schema.registry.retry.interval.inMillis";
+ public static final String SCHEMA_CREATION_TIME_KEY = "CreatedOn";
Review comment:
If this is supposed to be an internal attribute, you won't need it as public
static but should be as close as possible to wherever you are using it. ( I am
a bit opposed to adding anything more into ConfigurationKeys but looks like it
is common practice that everyone is following.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 403167)
Time Spent: 1h 40m (was: 1.5h)
> Add configuration to preserve schema creation time in converter
> ---------------------------------------------------------------
>
> Key: GOBBLIN-1080
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1080
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Zihan Li
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
