[
https://issues.apache.org/jira/browse/GOBBLIN-1084?focusedWorklogId=403336&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403336
]
ASF GitHub Bot logged work on GOBBLIN-1084:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 14/Mar/20 03:06
Start Date: 14/Mar/20 03:06
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2924: [GOBBLIN-1084]
Refresh flowgraph when templates are modified
URL: https://github.com/apache/incubator-gobblin/pull/2924#discussion_r392551209
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/core/GitFlowGraphMonitor.java
##########
@@ -128,11 +131,15 @@ public boolean shouldPollGit() {
*/
@Override
void processGitConfigChanges() throws GitAPIException, IOException {
- if (flowTemplateCatalog.isPresent() && (flowTemplateCatalog.get()
instanceof ObservingFSFlowEdgeTemplateCatalog)) {
- ObservingFSFlowEdgeTemplateCatalog catalog =
(ObservingFSFlowEdgeTemplateCatalog) flowTemplateCatalog.get();
- if (catalog.isShouldRefreshFlowGraph()) {
- this.gitRepo.initRepository();
- catalog.setShouldRefreshFlowGraph(false);
+ if (lock.tryLock()) {
Review comment:
Shouldn't we be using the lock defined in the ObservingFlowCatalog here?
Defining a new lock here is not useful since the GitFlowGraphMonitor is single
threaded.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 403336)
Time Spent: 1h 20m (was: 1h 10m)
> Refresh flowgraph when templates are modified
> ---------------------------------------------
>
> Key: GOBBLIN-1084
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1084
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
