sv2000 opened a new pull request #2928: GOBBLIN-1087: Track and report 
histogram of observed lag from Gobblin…
URL: https://github.com/apache/incubator-gobblin/pull/2928
 
 
   … Kafka pipeline
   
   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I 
have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin 
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references 
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1087
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if 
applicable):
   In this PR, we instrument the KafkaExtractor to track the observed latency 
of Kafka consumer records processed by the pipeline. Here, observed latency is 
measured as the time difference between processing time of the record and the 
original creation time. The latency distribution is tracked in an HdrHistogram, 
which is serialized into a string when emitted as part of a 
GobblinTrackingEvent.
   
   
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for 
this extremely good reason:
   Added unit tests and a JMH benchmarking test.
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I 
have squashed multiple commits if they address the same issue. In addition, my 
commits follow the guidelines from "[How to write a good git commit 
message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to