sv2000 commented on a change in pull request #2927: Fix start
URL: https://github.com/apache/incubator-gobblin/pull/2927#discussion_r393926130
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java
##########
@@ -182,16 +182,14 @@ private static void
modifyStateIfRetryRequired(org.apache.gobblin.configuration.
}
}
- private static org.apache.gobblin.configuration.State
mergedProperties(org.apache.gobblin.configuration.State jobStatus,
- List<org.apache.gobblin.configuration.State> states) {
- Properties mergedProperties = new Properties();
+ private static org.apache.gobblin.configuration.State
mergeState(org.apache.gobblin.configuration.State state,
Review comment:
Might be worth adding a javadoc: "Merge states based on precedence. The
state instance in the 1st argument reflects the more recent state of a job (and
is thus, given higher priority) compared to the 2nd argument."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
