[ 
https://issues.apache.org/jira/browse/GOBBLIN-1099?focusedWorklogId=410737&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-410737
 ]

ASF GitHub Bot logged work on GOBBLIN-1099:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Mar/20 00:19
            Start Date: 27/Mar/20 00:19
    Worklog Time Spent: 10m 
      Work Description: codecov-io commented on issue #2940: GOBBLIN-1099: 
Handle orphaned Yarn containers in Gobblin-on-Yarn clus…
URL: 
https://github.com/apache/incubator-gobblin/pull/2940#issuecomment-604751963
 
 
   # 
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2940?src=pr&el=h1)
 Report
   > Merging 
[#2940](https://codecov.io/gh/apache/incubator-gobblin/pull/2940?src=pr&el=desc)
 into 
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/a63461257c3fcea8f4ff67087f8cb29be25d6baf&el=desc)
 will **decrease** coverage by `40.49%`.
   > The diff coverage is `0.00%`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/incubator-gobblin/pull/2940/graphs/tree.svg?width=650&height=150&src=pr&token=4MgURJ0bGc)](https://codecov.io/gh/apache/incubator-gobblin/pull/2940?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #2940       +/-   ##
   ============================================
   - Coverage     44.60%   4.11%   -40.50%     
   + Complexity     8980     750     -8230     
   ============================================
     Files          1936    1936               
     Lines         73234   73296       +62     
     Branches       8083    8089        +6     
   ============================================
   - Hits          32669    3016    -29653     
   - Misses        37515   69960    +32445     
   + Partials       3050     320     -2730     
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2940?src=pr&el=tree) 
| Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | 
[.../apache/gobblin/cluster/GobblinClusterManager.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2940/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkNsdXN0ZXJNYW5hZ2VyLmphdmE=)
 | `0.00% <0.00%> (-53.92%)` | `0.00 <0.00> (-26.00)` | |
   | 
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2940/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
 | `0.00% <0.00%> (-64.16%)` | `0.00 <0.00> (-27.00)` | |
   | 
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2940/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
 | `0.00% <0.00%> (-38.27%)` | `0.00 <0.00> (-14.00)` | |
   | 
[...n/compaction/action/CompactionWatermarkAction.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2940/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vYWN0aW9uL0NvbXBhY3Rpb25XYXRlcm1hcmtBY3Rpb24uamF2YQ==)
 | `0.00% <0.00%> (-77.05%)` | `0.00 <0.00> (-11.00)` | |
   | 
[...che/gobblin/salesforce/ResultChainingIterator.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2940/diff?src=pr&el=tree#diff-Z29iYmxpbi1zYWxlc2ZvcmNlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NhbGVzZm9yY2UvUmVzdWx0Q2hhaW5pbmdJdGVyYXRvci5qYXZh)
 | `0.00% <0.00%> (ø)` | `0.00 <0.00> (ø)` | |
   | 
[.../apache/gobblin/yarn/GobblinApplicationMaster.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2940/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbkFwcGxpY2F0aW9uTWFzdGVyLmphdmE=)
 | `0.00% <0.00%> (-18.06%)` | `0.00 <0.00> (-3.00)` | |
   | 
[...rg/apache/gobblin/yarn/GobblinYarnAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2940/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vR29iYmxpbllhcm5BcHBMYXVuY2hlci5qYXZh)
 | `0.00% <0.00%> (-21.17%)` | `0.00 <0.00> (-8.00)` | |
   | 
[...main/java/org/apache/gobblin/yarn/YarnService.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2940/diff?src=pr&el=tree#diff-Z29iYmxpbi15YXJuL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3lhcm4vWWFyblNlcnZpY2UuamF2YQ==)
 | `0.00% <0.00%> (-15.28%)` | `0.00 <0.00> (-4.00)` | |
   | 
[...c/main/java/org/apache/gobblin/util/FileUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2940/diff?src=pr&el=tree#diff-Z29iYmxpbi11dGlsaXR5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3V0aWwvRmlsZVV0aWxzLmphdmE=)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
   | 
[...n/java/org/apache/gobblin/fork/CopyableSchema.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2940/diff?src=pr&el=tree#diff-Z29iYmxpbi1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2ZvcmsvQ29weWFibGVTY2hlbWEuamF2YQ==)
 | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
   | ... and [1150 
more](https://codecov.io/gh/apache/incubator-gobblin/pull/2940/diff?src=pr&el=tree-more)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2940?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2940?src=pr&el=footer).
 Last update 
[a634612...2915df6](https://codecov.io/gh/apache/incubator-gobblin/pull/2940?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 410737)
    Time Spent: 0.5h  (was: 20m)

> Handle orphaned Yarn containers in Gobblin-on-Yarn clusters
> -----------------------------------------------------------
>
>                 Key: GOBBLIN-1099
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1099
>             Project: Apache Gobblin
>          Issue Type: Improvement
>          Components: gobblin-yarn
>    Affects Versions: 0.15.0
>            Reporter: Sudarshan Vasudevan
>            Assignee: Abhishek Tiwari
>            Priority: Major
>             Fix For: 0.15.0
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> A Yarn application may leave behind orphaned containers, which can happen due 
> to lost node managers. The orphaned containers however can continue to run 
> (potentially forever) as participants in the Helix cluster. This can cause 
> the following problems for a Gobblin-on-Yarn application:
>  # Double publish of data and commit of state
>  # Task failures and partition starvation during application restarts, as 
> Helix may assign tasks to the orphaned containers which have a stale state 
> and configuration
>  # Container failures on application restarts due to Helix instance name 
> collisions with orphaned containers
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to