sv2000 commented on a change in pull request #2941: [GOBBLIN-1100] Set average
fetch time in the KafkaExtractor even when…
URL: https://github.com/apache/incubator-gobblin/pull/2941#discussion_r399392080
##########
File path:
gobblin-modules/gobblin-kafka-common/src/main/java/org/apache/gobblin/source/extractor/extract/kafka/KafkaExtractor.java
##########
@@ -321,6 +322,11 @@ public void close() throws IOException {
this.workUnitState.setActualHighWatermark(this.nextWatermark);
if (isInstrumentationEnabled()) {
this.statsTracker.emitTrackingEvents(getMetricContext(),
this.lowWatermark, this.highWatermark, this.nextWatermark);
+ } else {
Review comment:
Should we move the isInstrumentationEnabled() check inside
emitTrackingEventsWithAdditionalTags() and emit tracking events if it is true?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
