[
https://issues.apache.org/jira/browse/GOBBLIN-1107?focusedWorklogId=414466&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-414466
]
ASF GitHub Bot logged work on GOBBLIN-1107:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/20 03:52
Start Date: 02/Apr/20 03:52
Worklog Time Spent: 10m
Work Description: codecov-io commented on issue #2947: GOBBLIN-1107:
Lazily initialize Helix TaskStateModelFactory in Gobbli…
URL:
https://github.com/apache/incubator-gobblin/pull/2947#issuecomment-607606287
#
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2947?src=pr&el=h1)
Report
> Merging
[#2947](https://codecov.io/gh/apache/incubator-gobblin/pull/2947?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-gobblin/commit/112e455dc6a4fd171a6bc3d4c2f7ee720eae2f3e&el=desc)
will **increase** coverage by `0.01%`.
> The diff coverage is `81.25%`.
[](https://codecov.io/gh/apache/incubator-gobblin/pull/2947?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #2947 +/- ##
============================================
+ Coverage 45.56% 45.58% +0.01%
- Complexity 9153 9159 +6
============================================
Files 1936 1936
Lines 73292 73291 -1
Branches 8088 8088
============================================
+ Hits 33395 33408 +13
+ Misses 36800 36787 -13
+ Partials 3097 3096 -1
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-gobblin/pull/2947?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
|---|---|---|---|
|
[.../org/apache/gobblin/cluster/GobblinTaskRunner.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2947/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpblRhc2tSdW5uZXIuamF2YQ==)
| `66.53% <81.25%> (+1.44%)` | `32.00 <1.00> (+3.00)` | |
|
[...e/gobblin/runtime/app/ServiceBasedAppLauncher.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2947/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBwL1NlcnZpY2VCYXNlZEFwcExhdW5jaGVyLmphdmE=)
| `45.63% <0.00%> (-3.89%)` | `12.00% <0.00%> (ø%)` | |
|
[...lin/restli/throttling/ZookeeperLeaderElection.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2947/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2UvZ29iYmxpbi10aHJvdHRsaW5nLXNlcnZpY2Utc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3Jlc3RsaS90aHJvdHRsaW5nL1pvb2tlZXBlckxlYWRlckVsZWN0aW9uLmphdmE=)
| `70.00% <0.00%> (-2.23%)` | `13.00% <0.00%> (ø%)` | |
|
[...he/gobblin/metrics/reporter/ScheduledReporter.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2947/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9yZXBvcnRlci9TY2hlZHVsZWRSZXBvcnRlci5qYXZh)
| `59.09% <0.00%> (-1.52%)` | `14.00% <0.00%> (-1.00%)` | |
|
[...blin/service/FlowConfigV2ResourceLocalHandler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2947/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnVjJSZXNvdXJjZUxvY2FsSGFuZGxlci5qYXZh)
| `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
|
[...obblin/service/FlowConfigResourceLocalHandler.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2947/diff?src=pr&el=tree#diff-Z29iYmxpbi1yZXN0bGkvZ29iYmxpbi1mbG93LWNvbmZpZy1zZXJ2aWNlL2dvYmJsaW4tZmxvdy1jb25maWctc2VydmljZS1zZXJ2ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vc2VydmljZS9GbG93Q29uZmlnUmVzb3VyY2VMb2NhbEhhbmRsZXIuamF2YQ==)
| `13.67% <0.00%> (+0.34%)` | `2.00% <0.00%> (ø%)` | |
|
[.../apache/gobblin/runtime/api/JobExecutionState.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2947/diff?src=pr&el=tree#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvYXBpL0pvYkV4ZWN1dGlvblN0YXRlLmphdmE=)
| `80.37% <0.00%> (+0.93%)` | `24.00% <0.00%> (ø%)` | |
|
[...in/java/org/apache/gobblin/cluster/HelixUtils.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2947/diff?src=pr&el=tree#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvSGVsaXhVdGlscy5qYXZh)
| `40.47% <0.00%> (+5.55%)` | `16.00% <0.00%> (+2.00%)` | |
|
[.../org/apache/gobblin/metrics/RootMetricContext.java](https://codecov.io/gh/apache/incubator-gobblin/pull/2947/diff?src=pr&el=tree#diff-Z29iYmxpbi1tZXRyaWNzLWxpYnMvZ29iYmxpbi1tZXRyaWNzLWJhc2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vbWV0cmljcy9Sb290TWV0cmljQ29udGV4dC5qYXZh)
| `79.68% <0.00%> (+7.81%)` | `16.00% <0.00%> (+1.00%)` | |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2947?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-gobblin/pull/2947?src=pr&el=footer).
Last update
[112e455...d292aed](https://codecov.io/gh/apache/incubator-gobblin/pull/2947?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 414466)
Time Spent: 0.5h (was: 20m)
> Lazily initialize Helix TaskStateModelFactory in GobblinTaskRunner
> ------------------------------------------------------------------
>
> Key: GOBBLIN-1107
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1107
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-cluster
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Hung Tran
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Current behavior eagerly initializes the taskStateModelFactory inside the
> constructor. This causes Helix task assignment to be stuck when a Helix
> manager connection needs to be retried.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
