autumnust commented on a change in pull request #2947: GOBBLIN-1107: Lazily
initialize Helix TaskStateModelFactory in Gobbli…
URL: https://github.com/apache/incubator-gobblin/pull/2947#discussion_r402662777
##########
File path:
gobblin-cluster/src/test/java/org/apache/gobblin/cluster/GobblinTaskRunnerTest.java
##########
@@ -133,21 +141,31 @@ public void testBuildFileSystemConfig() {
Assert.assertEquals(fileSystem.getConf().get(HADOOP_OVERRIDE_PROPERTY_NAME),
"value");
}
- @Test
- public void testConnectHelixManagerWithRetry() {
- //Connect and disconnect the corrupt task runner to create a Helix
Instance set up.
+ /**
+ * A helper method that creates a partial instance structure in ZK.
+ */
+ private static void createPartialInstanceStructure(HelixManager
helixManager, String zkConnectString) {
Review comment:
Should this be moved into utils class newly created ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
