[
https://issues.apache.org/jira/browse/GOBBLIN-1068?focusedWorklogId=418729&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-418729
]
ASF GitHub Bot logged work on GOBBLIN-1068:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Apr/20 17:15
Start Date: 08/Apr/20 17:15
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on pull request #2907:
[GOBBLIN-1068]Clean up cyclic logic in task cancellation
URL: https://github.com/apache/incubator-gobblin/pull/2907#discussion_r405680816
##########
File path:
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/GobblinMultiTaskAttempt.java
##########
@@ -372,9 +379,9 @@ private boolean taskSuccessfulInPriorAttempt(String
taskId) {
* @param countDownLatch a {@link java.util.concurrent.CountDownLatch}
waited on for job completion
* @return a list of {@link Task}s from the {@link WorkUnit}s
*/
- private List<Task> runWorkUnits(CountUpAndDownLatch countDownLatch) {
-
+ private Pair<List<Task>, List<Future<?>>> runWorkUnits(CountUpAndDownLatch
countDownLatch) {
Review comment:
How about returning List<Pair<Task, Future<?>> ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 418729)
Time Spent: 3h 20m (was: 3h 10m)
> Clean cyclic logic in task cancellation in Gobblin Task
> -------------------------------------------------------
>
> Key: GOBBLIN-1068
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1068
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
