[
https://issues.apache.org/jira/browse/GOBBLIN-1113?focusedWorklogId=420096&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-420096
]
ASF GitHub Bot logged work on GOBBLIN-1113:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Apr/20 08:40
Start Date: 10/Apr/20 08:40
Worklog Time Spent: 10m
Work Description: arjun4084346 commented on pull request #2952:
[GOBBLIN-1113] Carry forward requester list property when updating flowconfig
URL: https://github.com/apache/incubator-gobblin/pull/2952#discussion_r406662247
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-server/src/main/java/org/apache/gobblin/service/FlowConfigResourceLocalHandler.java
##########
@@ -163,13 +163,17 @@ public UpdateResponse updateFlowConfig(FlowId flowId,
FlowConfig flowConfig, boo
throw new FlowConfigLoggedException(HttpStatus.S_400_BAD_REQUEST,
"flowName and flowGroup cannot be changed in update", null);
}
+ FlowConfig originalFlowConfig = getFlowConfig(flowId);
if (isUnscheduleRequest(flowConfig)) {
// flow config is not changed if it is just a request to un-schedule
- FlowConfig originalFlowConfig = getFlowConfig(flowId);
+ originalFlowConfig = getFlowConfig(flowId);
Review comment:
this line can be removed, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 420096)
Time Spent: 0.5h (was: 20m)
> Carry forward requester list property when updating flowconfig
> --------------------------------------------------------------
>
> Key: GOBBLIN-1113
> URL: https://issues.apache.org/jira/browse/GOBBLIN-1113
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
