arjun4084346 commented on a change in pull request #2952: [GOBBLIN-1113] Carry
forward requester list property when updating flowconfig
URL: https://github.com/apache/incubator-gobblin/pull/2952#discussion_r406940412
##########
File path:
gobblin-restli/gobblin-flow-config-service/gobblin-flow-config-service-client/src/test/java/org/apache/gobblin/service/FlowConfigTest.java
##########
@@ -220,6 +221,7 @@ public void testUpdate() throws Exception {
//Assert.assertEquals(flowConfig.getProperties().size(), 2);
Assert.assertEquals(retrievedFlowConfig.getProperties().get("param1"),
"value1b");
Assert.assertEquals(retrievedFlowConfig.getProperties().get("param2"),
"value2b");
+
Assert.assertEquals(retrievedFlowConfig.getProperties().get(RequesterService.REQUESTER_LIST),
RequesterService.serialize(new ArrayList<>()));
Review comment:
Hmm, so there is no way to have a legitimate requester in tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
