sv2000 commented on a change in pull request #2954: [GOBBLIN-1114]
OrcValueMapper schema evolution up-conversion recursive
URL: https://github.com/apache/incubator-gobblin/pull/2954#discussion_r407133543
##########
File path:
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/mapreduce/orc/OrcValueMapper.java
##########
@@ -91,7 +113,9 @@ OrcStruct upConvertOrcStruct(OrcStruct orcStruct, Context
context) {
TypeDescription readerType = newSchemaTypes.get(indexInNewSchema);
if (isEvolutionValid(fileType, readerType)) {
Review comment:
Should isEvolutionValid() be inside a utils class?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
